Skip to content

Add double tap action#3879

Merged
iantrich merged 12 commits into
home-assistant:devfrom
iantrich:double-tap
Oct 16, 2019
Merged

Add double tap action#3879
iantrich merged 12 commits into
home-assistant:devfrom
iantrich:double-tap

Conversation

@iantrich
Copy link
Copy Markdown
Member

@iantrich iantrich commented Oct 3, 2019

Docs: home-assistant/home-assistant.io#10808

double_tap_action:
  action: more-info

@iantrich iantrich self-assigned this Oct 3, 2019
@iantrich
Copy link
Copy Markdown
Member Author

iantrich commented Oct 3, 2019

I want to revamp the action editor in another PR. Going to leave it off for now

@iantrich iantrich changed the title WIP Add double tap action Add double tap action Oct 3, 2019
@iantrich iantrich requested review from balloob and bramkragten and removed request for balloob October 3, 2019 19:36
Comment thread src/panels/lovelace/common/directives/long-press-directive.ts
Comment thread src/panels/lovelace/common/directives/long-press-directive.ts Outdated
Comment thread src/panels/lovelace/elements/hui-state-label-element.ts Outdated
Comment thread gallery/src/demos/demo-util-long-press.ts Outdated
Comment thread src/panels/lovelace/common/directives/long-press-directive.ts
Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, to merge after comments

@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 15, 2019

Just a quick usability thingy dbltap_action sounds sane, but it is abbreviated.
IMHO, we should avoid those abbreviations, it just makes it harder to understand for users less familiar with the system.

Suggestion: double_tap_action.

@iantrich
Copy link
Copy Markdown
Member Author

Yeah, I agree. I'll make the change

@iantrich iantrich merged commit df29a5b into home-assistant:dev Oct 16, 2019
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
@iantrich iantrich deleted the double-tap branch October 30, 2019 03:19
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants